XSS, Cross Site Scripting, ds.addthis.com, CWE-79, CAPEC-86

CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')

Report generated by CloudScan Vulnerability Crawler at Fri Feb 25 15:03:01 CST 2011.

1. Cross-site scripting (reflected) next

Summary

Severity:	High
Confidence:	Certain
Host:	http://ds.addthis.com
Path:	/red/psi/sites/www.itbusinessedge.com/p.json

Issue detail

The value of the callback request parameter is copied into the HTML document as plain text between tags. The payload ecd93<script>alert(1)</script>655f85f298b was submitted in the callback parameter. This input was echoed unmodified in the application's response.

This proof-of-concept attack demonstrates that it is possible to inject arbitrary JavaScript into the application's response.

Issue background

Reflected cross-site scripting vulnerabilities arise when data is copied from a request and echoed into the application's immediate response in an unsafe way. An attacker can use the vulnerability to construct a request which, if issued by another application user, will cause JavaScript code supplied by the attacker to execute within the user's browser in the context of that user's session with the application.

The attacker-supplied code can perform a wide variety of actions, such as stealing the victim's session token or login credentials, performing arbitrary actions on the victim's behalf, and logging their keystrokes.

Users can be induced to issue the attacker's crafted request in various ways. For example, the attacker can send a victim a link containing a malicious URL in an email or instant message. They can submit the link to popular web sites that allow content authoring, for example in blog comments. And they can create an innocuous looking web site which causes anyone viewing it to make arbitrary cross-domain requests to the vulnerable application (using either the GET or the POST method).

The security impact of cross-site scripting vulnerabilities is dependent upon the nature of the vulnerable application, the kinds of data and functionality which it contains, and the other applications which belong to the same domain and organisation. If the application is used only to display non-sensitive public content, with no authentication or access control functionality, then a cross-site scripting flaw may be considered low risk. However, if the same application resides on a domain which can access cookies for other more security-critical applications, then the vulnerability could be used to attack those other applications, and so may be considered high risk. Similarly, if the organisation which owns the application is a likely target for phishing attacks, then the vulnerability could be leveraged to lend credibility to such attacks, by injecting Trojan functionality into the vulnerable application, and exploiting users' trust in the organisation in order to capture credentials for other applications which it owns. In many kinds of application, such as those providing online banking functionality, cross-site scripting should always be considered high risk.

Issue remediation

In most situations where user-controllable data is copied into application responses, cross-site scripting attacks can be prevented using two layers of defenses:

Input should be validated as strictly as possible on arrival, given the kind of content which it is expected to contain. For example, personal names should consist of alphabetical and a small range of typographical characters, and be relatively short; a year of birth should consist of exactly four numerals; email addresses should match a well-defined regular expression. Input which fails the validation should be rejected, not sanitised.
User input should be HTML-encoded at any point where it is copied into application responses. All HTML metacharacters, including < > " ' and =, should be replaced with the corresponding HTML entities (< > etc).

In cases where the application's functionality allows users to author content using a restricted subset of HTML tags and attributes (for example, blog comments which allow limited formatting and linking), it is necessary to parse the supplied HTML to validate that it does not use any dangerous syntax; this is a non-trivial task.

Request

GET /red/psi/sites/www.itbusinessedge.com/p.json?callback=_ate.ad.hprecd93<script>alert(1)</script>655f85f298b&uid=4d5af32c71c2e1a5&url=http%3A%2F%2Fwww.itbusinessedge.com%2Fcm%2Fcommunity%2Fnews%2Fsec%2Fblog%2Fmicrosoft-warns-of-windows-mhtml-xss-vulnerability%2F%3Fcs%3D45331%2660a70%2522%253E%253CScRiPt%253Ealert(1)%253C%2FScRiPt%253E2feb06588c5%3D1&ref=http%3A%2F%2Fburp%2Fshow%2F13&1cd5s1w HTTP/1.1
Host: ds.addthis.com
Proxy-Connection: keep-alive
Referer: http://s7.addthis.com/static/r07/sh32.html
Accept: */*
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/534.13 (KHTML, like Gecko) Chrome/9.0.597.98 Safari/534.13
Accept-Encoding: gzip,deflate,sdch
Accept-Language: en-US,en;q=0.8
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.3
Cookie: psc=4; uid=4d5af32c71c2e1a5

Response

HTTP/1.1 200 OK
Server: Apache-Coyote/1.1
Content-Length: 556
Content-Type: text/javascript
Set-Cookie: bt=; Domain=.addthis.com; Expires=Tue, 15 Feb 2011 21:50:33 GMT; Path=/
Set-Cookie: loc=US%2CMjAwMDFOQVVTREMyMTg4MTAyOTUxMTAwMDAwVg%3d%3d; Domain=.addthis.com; Expires=Mon, 16 May 2011 21:50:33 GMT; Path=/
Set-Cookie: dt=X; Domain=.addthis.com; Expires=Thu, 17 Mar 2011 21:50:33 GMT; Path=/
Set-Cookie: di=%7B%7D..1297806633.60|1297806633.66; Domain=.addthis.com; Expires=Thu, 14-Feb-2013 21:50:28 GMT; Path=/
P3P: policyref="/w3c/p3p.xml", CP="NON ADM OUR DEV IND COM STA"
Expires: Tue, 15 Feb 2011 21:50:33 GMT
Cache-Control: max-age=0, no-cache, no-store
Pragma: no-cache
Date: Tue, 15 Feb 2011 21:50:33 GMT
Connection: close

_ate.ad.hprecd93<script>alert(1)</script>655f85f298b({"urls":["http://cspix.media6degrees.com/orbserv/hbpix?pixId=1598&pcv=45&ptid=100&tpv=00&tpu=4d5af32c71c2e1a5&curl=http%3a%2f%2fwww.itbusinessedge.com%2fcm%2fcommunity%2fnews%2fsec%2fblog%2fmicrosoft-
...[SNIP]...

2. Cookie scoped to parent domain previous next

Summary

Severity:	Information
Confidence:	Certain
Host:	http://ds.addthis.com
Path:	/red/psi/sites/www.itbusinessedge.com/p.json

Issue detail

The following cookies were issued by the application and is scoped to a parent of the issuing domain:

loc=US%2CMjAwMDFOQVVTREMyMTg4MTAyOTUxMTAwMDAwVg%3d%3d; Domain=.addthis.com; Expires=Mon, 16 May 2011 21:50:28 GMT; Path=/
di=%7B%7D..1297806628.60|1297806628.66; Domain=.addthis.com; Expires=Thu, 14-Feb-2013 18:43:05 GMT; Path=/

The cookies do not appear to contain session tokens, which may reduce the risk associated with this issue. You should review the contents of the cookies to determine their function.

Issue background

A cookie's domain attribute determines which domains can access the cookie. Browsers will automatically submit the cookie in requests to in-scope domains, and those domains will also be able to access the cookie via JavaScript. If a cookie is scoped to a parent domain, then that cookie will be accessible by the parent domain and also by any other subdomains of the parent domain. If the cookie contains sensitive data (such as a session token) then this data may be accessible by less trusted or less secure applications residing at those domains, leading to a security compromise.

Issue remediation

By default, cookies are scoped to the issuing domain and all subdomains. If you remove the explicit domain attribute from your Set-cookie directive, then the cookie will have this default scope, which is safe and appropriate in most situations. If you particularly need a cookie to be accessible by a parent domain, then you should thoroughly review the security of the applications residing on that domain and its subdomains, and confirm that you are willing to trust the people and systems which support those applications.

Request

GET /red/psi/sites/www.itbusinessedge.com/p.json?callback=_ate.ad.hpr&uid=4d5af32c71c2e1a5&url=http%3A%2F%2Fwww.itbusinessedge.com%2Fcm%2Fcommunity%2Fnews%2Fsec%2Fblog%2Fmicrosoft-warns-of-windows-mhtml-xss-vulnerability%2F%3Fcs%3D45331%2660a70%2522%253E%253CScRiPt%253Ealert(1)%253C%2FScRiPt%253E2feb06588c5%3D1&ref=http%3A%2F%2Fburp%2Fshow%2F13&1cd5s1w HTTP/1.1
Host: ds.addthis.com
Proxy-Connection: keep-alive
Referer: http://s7.addthis.com/static/r07/sh32.html
Accept: */*
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/534.13 (KHTML, like Gecko) Chrome/9.0.597.98 Safari/534.13
Accept-Encoding: gzip,deflate,sdch
Accept-Language: en-US,en;q=0.8
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.3
Cookie: psc=4; uid=4d5af32c71c2e1a5

Response

HTTP/1.1 200 OK
Server: Apache-Coyote/1.1
Content-Length: 515
Content-Type: text/javascript
Set-Cookie: bt=; Domain=.addthis.com; Expires=Tue, 15 Feb 2011 21:50:28 GMT; Path=/
Set-Cookie: loc=US%2CMjAwMDFOQVVTREMyMTg4MTAyOTUxMTAwMDAwVg%3d%3d; Domain=.addthis.com; Expires=Mon, 16 May 2011 21:50:28 GMT; Path=/
Set-Cookie: dt=X; Domain=.addthis.com; Expires=Thu, 17 Mar 2011 21:50:28 GMT; Path=/
Set-Cookie: di=%7B%7D..1297806628.60|1297806628.66; Domain=.addthis.com; Expires=Thu, 14-Feb-2013 18:43:05 GMT; Path=/
P3P: policyref="/w3c/p3p.xml", CP="NON ADM OUR DEV IND COM STA"
Expires: Tue, 15 Feb 2011 21:50:28 GMT
Cache-Control: max-age=0, no-cache, no-store
Pragma: no-cache
Date: Tue, 15 Feb 2011 21:50:28 GMT
Connection: close

_ate.ad.hpr({"urls":["http://cspix.media6degrees.com/orbserv/hbpix?pixId=1598&pcv=45&ptid=100&tpv=00&tpu=4d5af32c71c2e1a5&curl=http%3a%2f%2fwww.itbusinessedge.com%2fcm%2fcommunity%2fnews%2fsec%2fblog%
...[SNIP]...

3. Cookie without HttpOnly flag set previous

Summary

Severity:	Information
Confidence:	Certain
Host:	http://ds.addthis.com
Path:	/red/psi/sites/www.itbusinessedge.com/p.json

Issue detail

The following cookies were issued by the application and do not have the HttpOnly flag set:

loc=US%2CMjAwMDFOQVVTREMyMTg4MTAyOTUxMTAwMDAwVg%3d%3d; Domain=.addthis.com; Expires=Mon, 16 May 2011 21:50:28 GMT; Path=/
di=%7B%7D..1297806628.60|1297806628.66; Domain=.addthis.com; Expires=Thu, 14-Feb-2013 18:43:05 GMT; Path=/

The cookies do not appear to contain session tokens, which may reduce the risk associated with this issue. You should review the contents of the cookies to determine their function.

Issue background

If the HttpOnly attribute is set on a cookie, then the cookie's value cannot be read or set by client-side JavaScript. This measure can prevent certain client-side attacks, such as cross-site scripting, from trivially capturing the cookie's value via an injected script.

Issue remediation

There is usually no good reason not to set the HttpOnly flag on all cookies. Unless you specifically require legitimate client-side scripts within your application to read or set a cookie's value, you should set the HttpOnly flag by including this attribute within the relevant Set-cookie directive.

You should be aware that the restrictions imposed by the HttpOnly flag can potentially be circumvented in some circumstances, and that numerous other serious attacks can be delivered by client-side script injection, aside from simple cookie stealing.

Request

Response

Report generated by CloudScan Vulnerability Crawler at Fri Feb 25 15:03:01 CST 2011.