Report generated by Hoyt LLC at Sun Nov 07 17:51:23 CST 2010.

Cross Site Scripting Reports | Hoyt LLC Research

Summary

Severity:	High
Confidence:	Certain
Host:	http://engadget2.disqus.com
Path:	/thread/dnp_kinect_review_dnp/reply.html

Issue detail

The value of the default_text request parameter is copied into a JavaScript expression which is not encapsulated in any quotation marks. The payload e3480%3balert(1)//234a0fe37e0 was submitted in the default_text parameter. This input was echoed as e3480;alert(1)//234a0fe37e0 in the application's response.

This proof-of-concept attack demonstrates that it is possible to inject arbitrary JavaScript into the application's response.

Remediation detail

Echoing user-controllable data within a script context is inherently dangerous and can make XSS attacks difficult to prevent. If at all possible, the application should avoid echoing user data within this context.

Issue background

Reflected cross-site scripting vulnerabilities arise when data is copied from a request and echoed into the application's immediate response in an unsafe way. An attacker can use the vulnerability to construct a request which, if issued by another application user, will cause JavaScript code supplied by the attacker to execute within the user's browser in the context of that user's session with the application.

The attacker-supplied code can perform a wide variety of actions, such as stealing the victim's session token or login credentials, performing arbitrary actions on the victim's behalf, and logging their keystrokes.

Users can be induced to issue the attacker's crafted request in various ways. For example, the attacker can send a victim a link containing a malicious URL in an email or instant message. They can submit the link to popular web sites that allow content authoring, for example in blog comments. And they can create an innocuous looking web site which causes anyone viewing it to make arbitrary cross-domain requests to the vulnerable application (using either the GET or the POST method).

The security impact of cross-site scripting vulnerabilities is dependent upon the nature of the vulnerable application, the kinds of data and functionality which it contains, and the other applications which belong to the same domain and organisation. If the application is used only to display non-sensitive public content, with no authentication or access control functionality, then a cross-site scripting flaw may be considered low risk. However, if the same application resides on a domain which can access cookies for other more security-critical applications, then the vulnerability could be used to attack those other applications, and so may be considered high risk. Similarly, if the organisation which owns the application is a likely target for phishing attacks, then the vulnerability could be leveraged to lend credibility to such attacks, by injecting Trojan functionality into the vulnerable application, and exploiting users' trust in the organisation in order to capture credentials for other applications which it owns. In many kinds of application, such as those providing online banking functionality, cross-site scripting should always be considered high risk.

Remediation background

In most situations where user-controllable data is copied into application responses, cross-site scripting attacks can be prevented using two layers of defenses:

Input should be validated as strictly as possible on arrival, given the kind of content which it is expected to contain. For example, personal names should consist of alphabetical and a small range of typographical characters, and be relatively short; a year of birth should consist of exactly four numerals; email addresses should match a well-defined regular expression. Input which fails the validation should be rejected, not sanitised.
User input should be HTML-encoded at any point where it is copied into application responses. All HTML metacharacters, including < > " ' and =, should be replaced with the corresponding HTML entities (< > etc).

In cases where the application's functionality allows users to author content using a restricted subset of HTML tags and attributes (for example, blog comments which allow limited formatting and linking), it is necessary to parse the supplied HTML to validate that it does not use any dangerous syntax; this is a non-trivial task.

Request

GET /thread/dnp_kinect_review_dnp/reply.html?f=engadget2&t=dnp_kinect_review_dnp&ff=Times%20New%20Roman&default_text=Type%20your%20comment%20here.e3480%3balert(1)//234a0fe37e0&ifrs=&1289161547099 HTTP/1.1
Accept: image/jpeg, image/gif, image/pjpeg, application/x-ms-application, application/xaml+xml, application/x-ms-xbap, */*
Accept-Language: en-US
User-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET4.0C; .NET4.0E; .NET CLR 3.5.30729; .NET CLR 3.0.30729)
Accept-Encoding: gzip, deflate
Proxy-Connection: Keep-Alive
Host: engadget2.disqus.com
Cookie: test=1

Response

HTTP/1.1 200 OK
Date: Sun, 07 Nov 2010 22:26:04 GMT
Server: Apache/2.2.14 (Ubuntu)
Content-Language: en-us
Vary: Accept-Language,Cookie,Accept-Encoding
X-Nonce: -:2010-11-07T17:26:04.922030
Cache-Control: no-cache
Connection: close
Content-Type: text/html; charset=utf-8
Content-Length: 66752

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
   <head>
       <title></title>
       <meta http-equiv="Content-Type" content="text/html; charset
...[SNIP]...
= true;
   };
};


var comment = new function() {
   this.placeholder = {
       'name' : "Name",
       'email' : "Email",
       'website' : "Website",
       'textarea' : "Type your comment here.e3480;alert(1)//234a0fe37e0"
   };

   this.submitButtonValue = 'Submit';

   this.validateSubmit = function() {
       var message = (document.comment_form.message) ? document.comment_form.message : false;
       var author_email = (document
...[SNIP]...

Report generated by XSS.CX at Sun Nov 07 17:51:23 CST 2010.